Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix "Cannot read property 'props'" #8731

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 6, 2019

Issue: #8729

What I did

Add extra check to make sure we have docgen info after stripping away HOCs

@vercel
Copy link

vercel bot commented Nov 6, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/myyaiszfl
🌍 Preview: https://monorepo-git-8729-fix-no-docgen.storybook.now.sh

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patricklafrance
Copy link
Member

I think you should use hasDocgenSection. Seems to do exactly what you want ?

It doesn't seem to be used anywhere but it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants